Cleanup in Experiment Server - #14185

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.95%. Comparing base (3eb1fd7) to head (9eb7dcd).
⚠️ Report is 17 commits behind head on main.
✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main   #14185      +/-   ##
==========================================
+ Coverage   91.93%   91.95%   +0.02%     
==========================================
  Files         482      484       +2     
  Lines       33513    33639     +126     
==========================================
+ Hits        30809    30933     +124     
- Misses       2704     2706       +2     

Merging this PR will not alter performance

✅ 36 untouched benchmarks

_{Comparing andreas-el:experiment_server_touch_up (9eb7dcd) with main (293883c)}

The last commit does not look like a cleanup. Can you elaborate what kind of issue it solves? (since it adds complexity to the code)

The last commit does not look like a cleanup. Can you elaborate what kind of issue it solves? (since it adds complexity to the code)

I can put that in a separate PR. The issue listed code smells, including global variables. The last commit tries to battle exactly that, and this is surely up for debate if the change actually improves code quality, readability etc.

I can put that in a separate PR. The issue listed code smells, including global variables. The last commit tries to battle exactly that, and this is surely up for debate if the change actually improves code quality, readability etc.

I agree we can put this in a separate PR, and the. we can look into whether we can use lifespan for this global state issue.